Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace shortid with hyperid #565 #567

Merged
merged 1 commit into from
Dec 7, 2020
Merged

fix: replace shortid with hyperid #565 #567

merged 1 commit into from
Dec 7, 2020

Conversation

robertsLando
Copy link
Member

Fixes #565

@robertsLando robertsLando requested a review from mcollina December 7, 2020 15:03
@coveralls
Copy link

Pull Request Test Coverage Report for Build 406101085

  • 0 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.545%

Totals Coverage Status
Change from base Build 367670442: 0.0%
Covered Lines: 786
Relevant Lines: 787

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 7, 2020

Pull Request Test Coverage Report for Build 406101085

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.545%

Totals Coverage Status
Change from base Build 367670442: 0.0%
Covered Lines: 786
Relevant Lines: 787

💛 - Coveralls

Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@robertsLando robertsLando merged commit 831048b into master Dec 7, 2020
@robertsLando robertsLando deleted the fix#565 branch December 7, 2020 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Conflict with Passenger and Node Cluster module
3 participants